Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-395] Delegate AAVE/stkAAVE to TokenLogic #432

Merged
merged 6 commits into from
Aug 3, 2023
Merged

[BIP-395] Delegate AAVE/stkAAVE to TokenLogic #432

merged 6 commits into from
Aug 3, 2023

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Aug 2, 2023

@Xeonus
Copy link
Collaborator Author

Xeonus commented Aug 2, 2023

@Tritium-VLK : carefully review this payload. I was only able to create a json with the raw hex data based on karpatkey's template and looking at the proxy contract. I took the raw tx data from Karpatkey from here: https://safe-transaction-mainnet.safe.global/api/v1/safes/0x0EFcCBb9E2C09Ea29551879bd9Da32362b32fc89/multisig-transactions/

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

BIP validation results for file BIPs/2023-W31/BIP-395A.json:
Commit: 876728f3c6897042a790d0042f305b534cc096f4

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W31/BIP-395B.json:
Commit: 876728f3c6897042a790d0042f305b534cc096f4

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@Tritium-VLK Tritium-VLK force-pushed the BIP-395-AAVE-stkAAVE-delegation-TokenLogic branch from 08d5d2d to 3053407 Compare August 2, 2023 21:06
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

BIP validation results for file BIPs/2023-W31/BIP-395A.json:
Commit: 3053407382072b7780b5e0bf3df9ce9bae8d6f28

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W31/BIP-395B.json:
Commit: 3053407382072b7780b5e0bf3df9ce9bae8d6f28

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@Tritium-VLK Tritium-VLK mentioned this pull request Aug 2, 2023
Closed
Tritium-VLK
Tritium-VLK reviewed Aug 3, 2023
View reviewed changes
BIPs/2023-W31/BIP-395A.json Outdated Show resolved Hide resolved
BIPs/2023-W31/BIP-395B.json Outdated Show resolved Hide resolved
Tritium-VLK
Tritium-VLK previously approved these changes Aug 3, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

BIP validation results for file BIPs/2023-W31/BIP-395A.json:
Commit: 46c5aa94cba86ea968a87756a3f4d32744687be5

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W31/BIP-395B.json:
Commit: 46c5aa94cba86ea968a87756a3f4d32744687be5

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@Tritium-VLK Tritium-VLK merged commit 8320d8c into main Aug 3, 2023
@Tritium-VLK Tritium-VLK deleted the BIP-395-AAVE-stkAAVE-delegation-TokenLogic branch August 6, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xeonus @Tritium-VLK